Repository navigation
Allow legal persons to send name and email in disclosed attributes - #2971
Open
OlegPhenomenon wants to merge 2 commits into
Open
OlegPhenomenon wants to merge 2 commits into
OlegPhenomenon wants to merge 2 commits into
Conversation
Registrant center sends name and email in disclosed_attributes for org contacts (WhoIsEdit adds them for org registrants, DomainEditPage merges in attributes already stored on the contact). The registrant API only allowed phone for legal persons, so every save of such a contact failed with 400 "Legal person's data is visible by default and cannot be concealed", including plain email/phone changes. Accept name, email and phone for org contacts; address, fax and registrant_publishable are still rejected.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Registrant center fails to save org contacts with
400 Bad Request(reported by OÜ Otetaru, 11.10.2026):Registrant center sends
nameandemailindisclosed_attributesfor org contacts (WhoIsEditadds them for org registrants;DomainEditPagemerges in attributes already stored on the contact). The API allowed onlyphonefor legal persons (Contact::OPEN_LEGAL_ATTRIBUTES, since 86fad85 / #2488), so any save of such a contact failed — including plain email/phone changes. The frontend shows a generic "check phone format" message for every 400, hiding the real reason.Change
Contact::OPEN_LEGAL_ATTRIBUTES = %w[name email phone];address,fax,registrant_publishableare still rejected for orgs.Tests
name/emailupdating email and phone): fails on master with the exact production response, passes with the fix.test/integration/api/v1/registrant/+test/models/contact_test.rb: 74 runs, 0 failures.