Repository navigation
fix(WO17): override rows join the trailing parallel pass — cross-grammar parity - #842
Merged
Merged
Conversation
…- cross-grammar parity The first run of the cross-grammar parity harness (maps scripts/parse-parity.mjs) caught interscript-py appending unmatched override additions as bare stage rules while ts/ruby join ALL override rows into the trailing parallel block (§4.2.6) - bgnpcgn-tha compiled 344 vs 327+17, alalc-tha 1523 vs 327+1196: the additions ran as separate sequential gsubs instead of participating in the single longest-match pass with the rows they extend. _apply_override now mirrors the canonical merge: partition R by byte-exact from-equality, then when the expansion ends with a parallel block ALL of O joins it; otherwise O appends as stage-level rows. Two placement specs watched failing first (one item, kept-then- overrides order, one-pass execution). Suites: wf1/parser/constraints green; the golden (12,337 rows, in-process) green in-suite.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first run of the cross-grammar parity harness (maps
scripts/parse-parity.mjs, PR #270) caught interscript-py appending unmatched override additions as bare stage rules while the ruby reference and the ts runtime join ALL override rows into the trailing parallel block (§4.2.6): bgnpcgn-tha compiled 344 vs 327+17, alalc-tha 1523 vs 327+1196 — the additions ran as separate sequential gsubs instead of participating in the single longest-match pass they extend._apply_overridenow mirrors the canonical merge: partition by byte-exact from-equality; when the expansion ends with a parallel block, ALL of O joins it; otherwise O appends as stage-level rows.Verification
["b","a","c"]; one-pass execution"ac" → "AZ").