Repository navigation
fix(WF-1): use inside sequence/parallel blocks per spec 3.2 (ruby + py) - #852
Merged
Merged
Conversation
The canonical PG grammar's rule_line now accepts the use directive inside sequence/parallel blocks (sha 52949cb3... - previously b0f7a7ca...), and both consumers implement the rs-canonical semantics: - ruby: the concerns grammar + document_builder/node_adapter flatten a used ruleset's rules into the enclosing collection in position; an override block merges per-rule (child-wins on exact from-equality); a non-rule target (funcalls/stage runs inside the used ruleset) is a named load error - non-rule items cannot join a pass. - py: grammar regenerated via sync_isc_grammar.py (sha pin bumped, pin test enforces); the containment rejection in isc.py is removed and replaced by the same flatten + per-rule-merge + named-error path. rs is the reference implementation and is unchanged. No corpus map uses the constructs (428 maps parse unchanged). Gates: rake 428/0/11; py suite green (the one test_api failure is a pre-existing stale un-bul vector, fixed separately); py-vs-py parity 435/435 canonical + raw vs the hand parser; cross-grammar harness 412/435 identical - same three known divergence kinds as the clean-main baseline, no new divergences.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(WF-1): use inside sequence/parallel blocks per spec 3.2 (ruby + py)
The canonical PG grammar's rule_line now accepts the use directive
inside sequence/parallel blocks (sha 52949cb3... - previously
b0f7a7ca...), and both consumers implement the rs-canonical semantics:
used ruleset's rules into the enclosing collection in position; an
override block merges per-rule (child-wins on exact from-equality);
a non-rule target (funcalls/stage runs inside the used ruleset) is a
named load error - non-rule items cannot join a pass.
test enforces); the containment rejection in isc.py is removed and
replaced by the same flatten + per-rule-merge + named-error path.
rs is the reference implementation and is unchanged. No corpus map
uses the constructs (428 maps parse unchanged). Gates: rake 428/0/11;
py suite green (the one test_api failure is a pre-existing stale un-bul
vector, fixed separately); py-vs-py parity 435/435 canonical + raw vs
the hand parser; cross-grammar harness 412/435 identical - same three
known divergence kinds as the clean-main baseline, no new divergences.