Repository navigation
fix(isc): a duplicate ruleset declaration is a load error (G7, py canon) - #854
Merged
Merged
Conversation
ruby silently kept the FIRST definition; with in-block use the executed body was declaration-order dependent (audit probe tst-rscycle could pull content from BOTH definitions). The document builder now raises Interscript::MapLogicError "ruleset <name> declared more than once in <filename>", matching rs #19's builder check, ts #138's expandDocument check, and py's parse rejection. TDD: wf1 semantics spec red (loaded, kept first) -> green; rake 431/0/11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WO18 audit gap G7 - the ruby half (rs landed in interscript-rs#19, py rejects at parse, ts in interscript-ts#138). Ruby silently kept the FIRST
ruleset adefinition, and with in-blockusethe expansion could pull content from BOTH definitions (audit probetst-rscycle). The document builder now raisesInterscript::MapLogicError, 'ruleset "a" declared more than once in <filename>'.TDD: wf1 semantics spec red (loaded and kept first) then green; rake 431 examples / 0 failures / 11 pending; standardrb clean.