Skip to content

WO20: reverse-mode golden gate in the additivity workflow (#286) - #297

Merged
ronaldtse merged 1 commit into
mainfrom
wo20-reverse-gate-ci
Nov 16, 2026
Merged

ronaldtse merged 1 commit into
mainfrom
wo20-reverse-gate-ci

Conversation

@ronaldtse

Copy link
Copy Markdown
Contributor

Summary

WO20 (#286): wire the reverse-mode golden gate into maps-CI's additivity workflow. Reverse mode exists in all four runtimes (rs reference capture, ruby pin, ts/py compiled-IR ports) but had no cross-runtime golden; the rs branch (interscript/interscript-rs#32) captured it once — tests/golden/isc-reverse.jsonl, 10,024 rows over 313 maps (the reversed documents' own embedded tests, i.e. every row's src is a forward expected output) — and this workflow change replays it in every runtime job alongside the forward steps:

runtime forward (existing) reverse (new step)
rs tests/golden_capture.rs tests/golden_reverse_capture.rs
ts test/golden-isc-wf0.test.ts test/golden-isc-reverse.test.ts
ruby tools/isc_wf1_golden_gate.rb tools/isc_wf1_golden_gate.rb --reverse
py tests/test_golden_capture.py tests/test_golden_reverse.py
  • Maps whose reverse still diverges across the runtimes (ruby 568 rows/27 maps, ts 603/33, py 3215/123 measured on the first full-corpus capture — union 125) contribute no rows: the rs capture skips them via the checked-in manifest tests/golden/reverse-divergent-maps.txt, which documents the divergence families and shrinks to zero as the engines converge.
  • The forward golden steps are untouched (isc-wf0.jsonl, 13,745 rows — zero-delta re-verified).

Merge order

The three runtime branches must land before (or with) this change: interscript/interscript-rs#32 (capture + golden), interscript/interscript-ruby#865 (ruby + py replay), and the ts branch for wo20-reverse-gate-ts. Until then the reverse files are absent on the checked-out mains and every reverse step no-ops — skip-on-missing is uniform (rs/ts/py skip in-test; the ruby gate tool exits 0 with a notice).

Test plan

Each runtime job gains a reverse step alongside its forward step:
rs replays tests/golden_reverse_capture.rs, ts
test/golden-isc-reverse.test.ts, ruby tools/isc_wf1_golden_gate.rb
--reverse, py tests/test_golden_reverse.py — all against the
RS-captured reverse golden (interscript-rs
tests/golden/isc-reverse.jsonl: 10,024 rows over 313 maps, captured
once by iscrs capture --reverse; maps whose reverse still diverges
across the runtimes are excluded via the rs-side manifest
tests/golden/reverse-divergent-maps.txt, shrink-to-zero). The forward
golden steps are untouched.

Merge order: the three runtime branches (wo20-reverse-gate-rs,
wo20-reverse-gate-ruby, wo20-reverse-gate-ts) must land before (or
with) this change — until then the reverse files are absent on the
rs main checkout and every reverse step no-ops (skip-on-missing is
uniform: rs/ts/py skip in-test, the ruby tool exits 0).
@ronaldtse
ronaldtse merged commit 30b5b5e into main Nov 16, 2026
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant