Repository navigation
feat(errors): add rule_id to AnalysisSkippedByRuleError - #183
Merged
Merged
Conversation
matany90
force-pushed
the
feat/skipped-by-rule-error-rule-id
branch
from
October 25, 2026 10:57
127f631 to
9f6a03d
Compare
davidt99
approved these changes
Oct 25, 2026
When the server skips an analysis because a rule matched, the 409 body can carry the id of that rule under result.rule_id. Expose it on the error so callers can report which rule caused the skip without parsing the response. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
matany90
force-pushed
the
feat/skipped-by-rule-error-rule-id
branch
from
October 25, 2026 11:16
9f6a03d to
8b51194
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
AnalysisSkippedByRuleErrornow exposesrule_id, the id of the rule that skipped the analysis, read fromresult.rule_idin the 409 body when the server provides it.Changes
AnalysisSkippedByRuleError.rule_id(str | None), parsed defensively from the response;Nonewhen the body has noresult, norule_id, or is not JSON.Full description
Services that catch
AnalysisSkippedByRuleErrorcurrently have to reach intoerror.response.json()to learn which rule caused the skip. Newer server versions includerule_idnext tois_skipped_by_rulein the 409 result; this change surfaces it as a plain attribute, mirroring howAnalysisRateLimitErrorexposes its headers. Backward compatible: the attribute is simplyNoneagainst servers that do not send it.🤖 Generated with Claude Code