feat!(iOS): support for source-based Swift package - #8578
Open
theproducer wants to merge 28 commits into
Open
Conversation
theproducer
changed the title
theproducer
marked this pull request as ready for review
August 20, 2026 15:09
theproducer
requested review from
a team and
andredestro
and removed request for
a team
August 20, 2026 15:09
markemer
reviewed
Aug 20, 2026
| working-directory: ./core | ||
| test-ios: | ||
| runs-on: macos-15 | ||
| runs-on: macos-26-intel |
Contributor
Author
There was a problem hiding this comment.
No reason - other than just that macos-15 was Intel. I can try with the ARM variant, it'll probably work fine.
andredestro
reviewed
Aug 27, 2026
| self.loggingEnabled = false | ||
| } | ||
|
|
||
| self.localURL = URL(string: "\(descriptor.urlScheme)://\(descriptor.urlHostname)")! |
Contributor
There was a problem hiding this comment.
The force-unwrap turns a nil URL into a launch-time crash.
But I'm not 100% sure whether it's a possible scenario.
| options as NSDictionary | ||
| } | ||
|
|
||
| public static var jsDateFormatter: ISO8601DateFormatter { |
Contributor
There was a problem hiding this comment.
Was this change intentional? It was previously stored as a static variable, so this makes jsDateFormatter return a new instance on every access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Converts Capacitor's iOS library from an Xcode-project-based, dual CocoaPods/prebuilt-XCFramework distribution model to a single source-of-truth Swift Package Manager package, while keeping the CocoaPods path fully working and unchanged for existing apps.
Change Type
Rationale / Problems Fixed
Tests or Reproductions
Screenshots / Media
Platforms Affected
Notes / Comments