fix(cli): run gradle wrapper before root build.gradle migration - #8579
Open
jcesarmobile wants to merge 1 commit into
Open
fix(cli): run gradle wrapper before root build.gradle migration#8579jcesarmobile wants to merge 1 commit into
jcesarmobile wants to merge 1 commit into
Conversation
jcesarmobile
requested review from
ItsChaceD,
OS-pedrogustavobilro,
OS-ruimoreiramendes,
alexgerardojacinto,
andredestro,
eric-horodyski,
markemer and
theproducer
August 25, 2026 16:59
alexgerardojacinto
approved these changes
Aug 25, 2026
OS-pedrogustavobilro
approved these changes
Aug 26, 2026
OS-pedrogustavobilro
left a comment
OS-pedrogustavobilro
left a comment
Contributor
There was a problem hiding this comment.
Well caught.
I had looked through the commit history before to try and understand if there was a reasoning for that particular order, but could not find it.
The comment is a good add too, should prevent further blunders 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #8543 the order of updating files was changed to edit settings.gradle and app/build.gradle before updating gradle files as it could cause issues, but the root build.gradle was also moved to run before updating the wrapper files.
The wrapper files need to be updated before updating the root build.gradle as if the AGP version is not compatible with current gradle it will fail to update the wrapper files, it doesn't happen with current versions, but could break in the future, in example if we update to AGP 9.4.0.
Added a comment as it's not the first time the wrapper files update was moved after the root build.gradle update and broke in a following update.