fix(cli): restore Cordova Package.swift generator for Cap 9 - #8580
fix(cli): restore Cordova Package.swift generator for Cap 9#8580OS-pedrogustavobilro wants to merge 2 commits into
Conversation
|
@OS-pedrogustavobilro I tested this myself first and it worked fine on my test. Then I asked Claude to verify and this is what it told me:
|
…enerateCordovaPackageFile
|
Thanks for the review! I believe that is referring to https://github.com/ionic-team/capacitor/pull/8443/changes - I've added it in this commit 24a0912 |
Description
Restores
buildBinaryTargetEntries,buildResourcesText,buildDependencyTexts,buildCSettingsText, and the weak/required system-framework linker-settings logic ingenerateCordovaPackageFile()'s generatedPackage.swiftbranch.Change Type
Rationale / Problems Fixed
These methods were originally added by #8445, #8447, #8448, #8455, and #8457 on
main, but then were collectively lost on a merge frommaintonextbranch:nexthad already relocated this generator intocli/src/util/cordova-ios.ts(via #8328's Cordova-optional refactor), somain's still-monolithic update.ts was probably incorrectly treated as a stale deletion and none of the five PRs' new content was ported into Capacitor 9.It's likely this has been like this for some time, and simply it missed us
I analysed other commits and merges (along with Claude 🤖), did not find any other kind of these issues
Tests or Reproductions
Test current Capacitor 9 alpha with a Cordova Plugin that requires updates to the auto-generated
Package.swiftfile (I chose https://github.com/OutSystems/cordova-outsystems-healthfitness that contains an xcframework). You'll find that it fails to build on Xcode, but with this PR it builds.Platforms Affected
Notes / Comments
For PR reviewers: