Repository navigation
feastdate 1.0.5: refuse Sundays the year did not have; document the CLI year range - #2
Merged
Merged
Conversation
…LI year range A misread numeral used to answer a plausible date in the next season: Dom. 28. Trin. 1680 gave Sun 19 Dec 1680, the 4th Sunday of Advent, and Dom. 7. p. Epiph. 1680 gave a Sunday two weeks into Septuagesima. The count is now checked against the year: the Sundays after Trinity run up to Advent 1 (22 to 27 of them) and the Sundays after Epiphany up to Septuagesima (1 to 6). A Sunday numbered 0 is refused, and so is a feria outside 1 to 7 (Fer. 9. Pasch. used to answer Easter + 8). The README and --help said a separate year could be 1 to 9999, but the CLI reads a separate last word as a year only from three digits up, on purpose: "Dom. Trin." 9 could be an ordinal, and reading it as AD 9 would answer in silence. The docs now say 100 to 9999, and the "no year" error says why a one- or two-digit last word was not taken as a year. --easter and the Python API still take any year from 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A misread numeral used to answer a plausible date in the next season:
Dom. 28. Trin. 1680 gave Sun 19 Dec 1680, the 4th Sunday of Advent, and
Dom. 7. p. Epiph. 1680 gave a Sunday two weeks into Septuagesima. The
count is now checked against the year: the Sundays after Trinity run up
to Advent 1 (22 to 27 of them) and the Sundays after Epiphany up to
Septuagesima (1 to 6). A Sunday numbered 0 is refused, and so is a feria
outside 1 to 7 (Fer. 9. Pasch. used to answer Easter + 8).
The README and --help said a separate year could be 1 to 9999, but the
CLI reads a separate last word as a year only from three digits up, on
purpose: "Dom. Trin." 9 could be an ordinal, and reading it as AD 9
would answer in silence. The docs now say 100 to 9999, and the "no year"
error says why a one- or two-digit last word was not taken as a year.
--easter and the Python API still take any year from 1.