Payload gate: compare documentation by path, not basename - #21
Merged
Merged
Conversation
The first attested release run for 0.1.0 (workflow_dispatch on public main c16c46b, run 36557987409) stopped at the package payload gate, before any attestation: "deb and rpm ship DIFFERENT documentation". Both packages ship the same nine files. The gate compared basenames, and 0.1.0 installs its guides in docs/: tar lists that directory as "docs/" (an empty basename), rpm as "docs". A basename comparison also could never see a guide installed in the wrong directory. The gate now compares paths relative to /usr/share/doc/isedraf, regular files only (tar directory entries end in "/", rpm reports modes). On the GA packages: "deb and rpm ship the same 9 documentation files". Falsification: "D-86 the rpm and the deb ship different documentation" did not commit its mutation, so build.sh refused the dirty tree and the gate's "no packages" failure matched its loose evidence - detection for the wrong reason. It now commits first, like the other packaging injections, and requires the real evidence. New: "D-86 the rpm installs a guide outside docs/", which the basename comparison could not detect. Both were shown to pass on real builds and fail on the mutation in harness-style sandboxes. Assisted-by: Claude (implementation agent, Claude Code) Signed-off-by: Antonios Voulvoulis <contact@itcms.gr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Payload gate: compare documentation by path, not basename
The first attested release run for 0.1.0 (workflow_dispatch on public main
c16c46b, run 36557987409) stopped at the package payload gate, before any
attestation: "deb and rpm ship DIFFERENT documentation". Both packages ship
the same nine files. The gate compared basenames, and 0.1.0 installs its
guides in docs/: tar lists that directory as "docs/" (an empty basename),
rpm as "docs". A basename comparison also could never see a guide installed
in the wrong directory.
The gate now compares paths relative to /usr/share/doc/isedraf, regular files
only (tar directory entries end in "/", rpm reports modes). On the GA
packages: "deb and rpm ship the same 9 documentation files".
Falsification: "D-86 the rpm and the deb ship different documentation" did
not commit its mutation, so build.sh refused the dirty tree and the gate's
"no packages" failure matched its loose evidence - detection for the wrong
reason. It now commits first, like the other packaging injections, and
requires the real evidence. New: "D-86 the rpm installs a guide outside
docs/", which the basename comparison could not detect. Both were shown to
pass on real builds and fail on the mutation in harness-style sandboxes.
Assisted-by: Claude (implementation agent, Claude Code)