alembic configuration is moved so updated dockerfiles - #139
Merged
Conversation
prasad-sawantdesai
requested review from
SimonPinches,
Yannicked,
maarten-ic and
olivhoenen
as code owners
October 1, 2026 08:30
Yannicked
approved these changes
Oct 1, 2026
olivhoenen
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#132 moved the Alembic migrations from alembic/ to src/simdb/database/migrations/ and pointed
script_location in alembic.ini there. Dockerfile and Dockerfile.dev still had COPY alembic/
./alembic/, so on a clean checkout every image build failed with:
failed to compute cache key: "/alembic": not found
fixed by dropping this line in docker files