Skip to content

Add option to give weights to parameterisation - #202

Merged
SBlokhuizen merged 9 commits into
developfrom
feature/weighted-parameterisation
Sep 28, 2026
Merged

SBlokhuizen merged 9 commits into
developfrom
feature/weighted-parameterisation

Conversation

@SBlokhuizen

@SBlokhuizen SBlokhuizen commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Adds some quality of life improvements to give the user more freedom in designing the desired boundary shape. You can now:

  • Add weighting to the shape parameterisation, so NICE fits a specific of the shape more closely.
  • Add weighted points on top of a parameterized shape, e.g. to pin the strike points.
  • Edit weighted points directly on the plot, click to add, drag to move, select and backspace to delete.

Example weighting different regions

No weighting Adding weighting to the top region Weighting near x-point
No weighting Adding weighting to the top region Weighting near x-point

Example Specifying strike points

Without strike points With strike points
Without strike points With strike points
Screenshot From 2026-09-23 11-09-40 Screenshot From 2026-09-23 11-09-40

@SBlokhuizen
SBlokhuizen force-pushed the feature/weighted-parameterisation branch from 1e5c7f4 to 64c244c Compare September 23, 2026 08:49
@SBlokhuizen
SBlokhuizen marked this pull request as ready for review September 23, 2026 09:17
Comment thread waveform_editor/gui/shape_editor/plasma_shape.py
Comment thread waveform_editor/gui/shape_editor/nice_plotter.py Outdated
Comment thread waveform_editor/gui/shape_editor/nice_plotter.py
Comment thread waveform_editor/gui/shape_editor/plasma_shape.py Outdated
Comment thread waveform_editor/shape_editor/plasma_shape_calc.py Outdated
@ioan-alexandra

Copy link
Copy Markdown
Collaborator

small nitpick can the table be inside the container for extra points?
image

Comment thread waveform_editor/gui/shape_editor/plasma_shape.py
Comment thread waveform_editor/gui/shape_editor/plasma_shape.py
Comment thread waveform_editor/gui/shape_editor/plasma_shape.py
@SBlokhuizen
SBlokhuizen merged commit 048df95 into develop Sep 28, 2026
6 checks passed
@SBlokhuizen
SBlokhuizen deleted the feature/weighted-parameterisation branch September 28, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants