fix: review existing PRs in a standalone workflow - #1417
Draft
ivankuznetsov wants to merge 5 commits into
Draft
ivankuznetsov wants to merge 5 commits into
ivankuznetsov wants to merge 5 commits into
Conversation
Keep the existing workflow order and append pr-review expectations, matching the built-in registry. Reproduces and fixes both failures from PR 1417 CI.
Only stage the old task path when it has tracked files. Preserve the full legacy evidence in the new standalone review, including tasks never committed by the old importer. Cover the live Webmail failure with a real-Git test.
Share workflow-aware verb resolution between stage commands, queued dispatch and worker validation. Standalone review and archive must target 1-review and 2-done rather than coding stages. Add regressions for both paths.
Carry workflow metadata through the shared synthetic task facade and derive its stage from the owning task folder. This keeps standalone reviewer session events from being written into the journal as coding-workflow events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hive review --pr Nnow runs a standalonepr-reviewworkflow (1-review→2-done) through the existing review council. It has no development, PR creation, artifacts or finalization stages.Test plan
2-done.git diff --checkclean.Notes for reviewer
Workflow identity is immutable in the control plane, so migration creates a replacement task ID and retains the old folder under
migration/coding. Migration refuses dirty or conflicting worktrees and retains a recovery backup if rollback fails. The remote-head fence fails closed if publication succeeds but its local identity receipt cannot be persisted.This changes source behavior only. The installed dogfood daemon and the existing Webmail review task have not been migrated. The PR remains draft pending hosted validation.