Repository navigation
Remove temp directories that tests leave behind - #60
Merged
Merged
Conversation
- Add tempDir helper with afterAll cleanup - Use it in nine leaking test files Signed-off-by: j-ctang <272994374+j-ctang@users.noreply.github.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Owner
Author
|
Verdict: Ready to merge Review tier: S No blocking findings. Follow-ups (outside this PR):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49
Risk: risk:low
Summary
test/tempDir.ts: creates temp dirs and removes them inafterAll.src/or config changes.Before/After
jev-*entries left after onenpx jest --runInBandwith a freshTMPDIR:Real
os.tmpdir(), counted before and afternpm test: 12940 -> 12940 (no new entries). With a planted failure insavedChoice.test.ts, the run fails and leaves 0jev-*dirs.npm run checkpasses.Commit History
Sensitive Changes
None.
Rollback
git revert <merge-sha>