Skip to content

fix: treat numeric slider answers as non-empty - #12

Merged
MadebyLeopold merged 1 commit into
jackpoll-org:masterfrom
laribright:fix/slider-answer-conditional-logic
Oct 13, 2026
Merged

MadebyLeopold merged 1 commit into
jackpoll-org:masterfrom
laribright:fix/slider-answer-conditional-logic

Conversation

@laribright

Copy link
Copy Markdown
Contributor

Problem

Conditional logic treats every numeric slider answer as empty because Object.keys(number) returns an empty array.

This incorrectly hides questions and sections using notEmpty, and shows those using empty, even when a slider has a valid answer.

Fix

Treat numeric answers, including zero, as non-empty. This matches the existing answer-validation behavior.

Tests

Added regression cases for slider values 0, 5, and 100 covering both empty and notEmpty.

image

@MadebyLeopold
MadebyLeopold merged commit 6a4fef9 into jackpoll-org:master Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants