Skip to content

fix(googlechat): keep Chat markup in Linus answers - #20

Merged
jai merged 5 commits into
fix/googlechat-maintained-main-2026-10-15from
patch/linus-googlechat-format-2026-11-09
Nov 9, 2026
Merged

jai merged 5 commits into
fix/googlechat-maintained-main-2026-10-15from
patch/linus-googlechat-format-2026-11-09

Conversation

@jai

@jai jai commented Nov 9, 2026

Copy link
Copy Markdown
Owner

What Problem This Solves

Linus has the same Chat markup bug as the shared gateway (#19). Chat apps created after 2026-10-16 read message text as Markdown by default, so single line breaks are lost and <url|label> links show literally.

User Impact

Linus's answers keep their line breaks and labelled links.

Why This Change Was Made

Ports the shared gateway fix: message creates and edits send markupSyntax: MARKUP_SYNTAX_CHAT with their text. Cards-only messages are unchanged. Also fixes one curly lint error in a #16 test.

Evidence

285 focused tests, the production extension typecheck, type-aware lint and formatting checks passed. Not deployed: Linus currently runs the pre-#16 image from main (see Related).

Stacked on #16. Related: ENG-3461 (Chat ordering and fleet patch alignment, In Progress).

jai and others added 2 commits November 8, 2026 10:59
Append final answers through durable delivery while retaining one temporary activity message. Carry source thread context independently of sessions, restore opt-in room sessions, and settle queued or explicit sends only after confirmed source delivery.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T05:31:42.517384Z be351a4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jai
jai changed the base branch from patch/linus-googlechat-2026-11-08 to fix/googlechat-maintained-main-2026-10-15 November 9, 2026 12:24
# Conflicts:
#	FORK_PATCHES.md
#	extensions/googlechat/src/monitor.test.ts
@jai
jai merged commit 5111cdd into fix/googlechat-maintained-main-2026-10-15 Nov 9, 2026
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant