Skip to content

fix(googlechat): stop duplicate shared gateway answers after message-tool sends - #23

Merged
jai merged 1 commit into
maintain/googlechat-patch-stack-2026-10-17from
fix/shared-googlechat-message-tool-receipt-2026-11-10
Nov 10, 2026
Merged

jai merged 1 commit into
maintain/googlechat-patch-stack-2026-10-17from
fix/shared-googlechat-message-tool-receipt-2026-11-10

Conversation

@jai

@jai jai commented Nov 9, 2026

Copy link
Copy Markdown
Owner

What Problem This Solves

The shared gateway carries the same gap that made SysOps post one answer twice (#22). When an agent sends its answer with the message tool (final: true) in the source thread, the send returns no receipt, so the run cannot prove the answer reached the source thread and settled-turn finalization posts a second copy.

User Impact

An answer sent through the message tool appears once.

Why This Change Was Made

Ports #22: the Google Chat send action returns a receipt with the sent message names and the thread Chat confirmed. No receipt is attached when Chat sent nothing. The layer-7 partial-delivery error path is unchanged.

Evidence

The action regressions failed before the port. A source-reply classification case with the real Google Chat payload is delivered with the receipt and not delivered without it. 312 Google Chat and source-reply tests, extension typecheck and lint passed.

Not deployed yet.

Related: ENG-3461 (Chat ordering and fleet patch alignment, In Progress).

…ge-tool sends

Port of #22. A message-tool send that inherits the source thread returned no receipt, so source-reply completion could not prove the answer landed in the current thread, and settled-turn finalization posted it again. Receipts list only sent messages and Chat's confirmed thread.
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-09T23:56:08.424598Z
We couldn’t complete this review. Comment @codex review to try again.
2447fd1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@jai
jai merged commit 1bb039d into maintain/googlechat-patch-stack-2026-10-17 Nov 10, 2026
255 of 267 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant