Repository navigation
fix(googlechat): stop duplicate shared gateway answers after message-tool sends - #23
Merged
Conversation
…ge-tool sends Port of #22. A message-tool send that inherits the source thread returned no receipt, so source-reply completion could not prove the answer landed in the current thread, and settled-turn finalization posted it again. Receipts list only sent messages and Chat's confirmed thread.
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
jai
merged commit Nov 10, 2026
1bb039d
into
maintain/googlechat-patch-stack-2026-10-17
255 of 267 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
The shared gateway carries the same gap that made SysOps post one answer twice (#22). When an agent sends its answer with the
messagetool (final: true) in the source thread, the send returns no receipt, so the run cannot prove the answer reached the source thread and settled-turn finalization posts a second copy.User Impact
An answer sent through the message tool appears once.
Why This Change Was Made
Ports #22: the Google Chat
sendaction returns a receipt with the sent message names and the thread Chat confirmed. No receipt is attached when Chat sent nothing. The layer-7 partial-delivery error path is unchanged.Evidence
The action regressions failed before the port. A source-reply classification case with the real Google Chat payload is delivered with the receipt and not delivered without it. 312 Google Chat and source-reply tests, extension typecheck and lint passed.
Not deployed yet.
Related: ENG-3461 (Chat ordering and fleet patch alignment, In Progress).