Repository navigation
Conversation
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Google Chat reports a DM between two humans that has the Chat app added as spaceType DIRECT_MESSAGE, the same as the 1:1 app DM. The monitor treated both as direct, so with the default dmScope "main" every such DM shared the owner's main session, and the agent saw only the sender's name. Treat a DIRECT_MESSAGE space as direct only when it is the 1:1 app DM (singleUserBotDm, or deprecated type DM). type ROOM means a human DM, which now routes as a group and so applies the groups policy and mention gate. When a payload carries neither marker, count the space's human members with a cached members.list call, and keep it direct if the lookup fails. Legacy payloads without type metadata keep their group default. Unnamed DMs and group chats are labeled with their members, for example "DM: Alice, Bob", so the agent knows who is in the conversation.
jai
force-pushed
the
fix/googlechat-multi-human-dm-routing
branch
from
November 10, 2026 12:52
156b4fb to
5940265
Compare
jai
changed the base branch from
fix/googlechat-dm-activity
to
patch/shared-googlechat-format-2026-11-09
November 10, 2026 12:52
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Google Chat reports a DM between two humans that has the Chat app added as
spaceType: DIRECT_MESSAGE, the same as the owner's 1:1 app DM. The monitor classified both asdirect, so with the defaultdmScope: "main"every such DM joinedagent:finn:main. The agent saw only the sender's name and did not know who else was in the room.Live Chat API reads on jai-work's spaces (app auth):
spaceType: DIRECT_MESSAGE,type: DM,singleUserBotDm: true, one human member.spaces/-dPlRiAAAAEand 11 other human DMs:spaceType: DIRECT_MESSAGE,type: ROOM, nosingleUserBotDm, two human members.Change
DIRECT_MESSAGEspace isdirectonly when it is the 1:1 app DM (singleUserBotDm: true, or deprecatedtype: DM).type: ROOMroutes as a group.spaces.members.listcall. If the lookup fails, keep the space direct.DM: Jai Govindani, Badiru Sulaimon Kolapo.findDirectMessageresults staydirectfor outbound session routing.On jai-work,
groups["*"](requireMention: true, users: Jai) now applies to these DMs. Jai's @mentions get through. Messages from the other human, or with no mention, are dropped.The owner's 1:1 DM still uses
dmScope: "main".Validation
extensions/googlechat: 36 files, 292 tests pass, including new classification, member-lookup, cache, label and access-policy cases.tsgoandpnpm build: passed on the 2026.9.7 port; rerunning on this base.Layer 11 of the shared stack (
FORK_PATCHES.md). Not deployed.