Skip to content

fix(googlechat): keep progress text above the activity status - #36

Merged
jai merged 1 commit into
maintain/googlechat-patch-stack-2026-10-17from
fix/googlechat-progress-with-status
Nov 11, 2026
Merged

jai merged 1 commit into
maintain/googlechat-patch-stack-2026-10-17from
fix/googlechat-progress-with-status

Conversation

@jai

@jai jai commented Nov 11, 2026

Copy link
Copy Markdown
Owner

Cosmo's progress update ("All 12 removals are verified…") appeared in the activity message and was then overwritten by "🛠️ Running a tool…" on the next tool call.

The activity message now shows the latest progress text, with the current status label on a line under it. A turn that ends without an answer still keeps only the progress text (#33). Progress is trimmed to 3,800 characters when a status line follows, to stay under Chat's limit.

Tests: Google Chat 310/310 (3 new in monitor-status-message.test.ts); extension tsgo clean.

Tool status labels overwrote progress folded into the activity message, so a result-like progress update briefly appeared and then reverted to "Running a tool…". The activity message now shows the latest progress text with the current status label on a line under it.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T14:41:30.701337Z 6a59000 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jai

jai commented Nov 11, 2026

Copy link
Copy Markdown
Owner Author

Codex review (CLI): APPROVE, no correctness findings.

@jai
jai merged commit b6c487f into maintain/googlechat-patch-stack-2026-10-17 Nov 11, 2026
15 of 18 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6a59000db0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

let progressText: string | undefined;
let statusLine: string | undefined;
const compose = () =>
[statusLine ? progressText?.slice(0, 3800) : progressText, statusLine]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Respect textChunkLimit when appending the status

When channels.googlechat.textChunkLimit is configured, monitor.ts has already formatted the progress chunk up to that hard cap, but this fixed 3,800-code-unit slice then appends two newlines and the status label without considering the configured limit or its byte-based formatter. For example, a 64-byte progress chunk becomes an approximately 90-byte PATCH, and a byte-full default chunk containing multibyte text also exceeds its cap. Budget the combined progress and status using the account's actual chunk limit and the same measurement unit before updating the message.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant