Skip to content

fix(calendar): Clear timed fields in all-day updates [AI-964] - #2

Open
finn-atlas wants to merge 2 commits into
jai:jai/chat-rich-messagesfrom
finn-atlas:fix/ai-964-calendar-all-day
Open

finn-atlas wants to merge 2 commits into
jai:jai/chat-rich-messagesfrom
finn-atlas:fix/ai-964-calendar-all-day

Conversation

@finn-atlas

@finn-atlas finn-atlas commented Nov 21, 2026 •

Copy link
Copy Markdown

Backports openclaw#1349 onto the currently deployed jai/chat-rich-messages branch.

Closes openclaw#1348

What Problem This Solves

A timed Google Calendar event can fail with 400 Invalid start time when calendar update --all-day changes it to an all-day event. The patch sets the all-day date but leaves the existing timed fields in Google's nested event data.

User Impact

The deployed custom build can convert events between timed and all-day forms without leaving incompatible start or end fields.

Why This Change Was Made

Update requests now send JSON null values for the previous time representation. All-day updates clear dateTime and timeZone. Timed updates clear date.

Evidence

Focused calendar tests pass on the deployed custom branch for both conversions, recurring updates, and restoring reminder defaults.

Dry runs on the upstream patch send dateTime: null and timeZone: null with each all-day date, including recurring events.

The same changes are under upstream review in openclaw#1349.

make ci completed formatting and lint checks. Its full test run found two unrelated Gmail failures that reproduce unchanged on the target branch jai/chat-rich-messages:

  • TestGmailDraftsRawDirectTokenRequiresAccount
  • TestGmailSendRawDirectTokenRequiresConcreteAccount

@finn-atlas

Copy link
Copy Markdown
Author

Upstream ClawSweeper source review found no code finding on the identical patch, but requires a live Google Calendar round trip before merge: openclaw#1349 (comment)

That write proof is not available in this repair because the originating operator prohibited calendar changes and no authorized disposable calendar target was provided. Keep this PR open until the upstream proof hold is cleared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant