Repository navigation
fix(calendar): Clear timed fields in all-day updates [AI-964] - #2
Open
finn-atlas wants to merge 2 commits into
Open
finn-atlas wants to merge 2 commits into
finn-atlas wants to merge 2 commits into
Conversation
Author
|
Upstream ClawSweeper source review found no code finding on the identical patch, but requires a live Google Calendar round trip before merge: openclaw#1349 (comment) That write proof is not available in this repair because the originating operator prohibited calendar changes and no authorized disposable calendar target was provided. Keep this PR open until the upstream proof hold is cleared. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports openclaw#1349 onto the currently deployed
jai/chat-rich-messagesbranch.Closes openclaw#1348
What Problem This Solves
A timed Google Calendar event can fail with
400 Invalid start timewhencalendar update --all-daychanges it to an all-day event. The patch sets the all-day date but leaves the existing timed fields in Google's nested event data.User Impact
The deployed custom build can convert events between timed and all-day forms without leaving incompatible start or end fields.
Why This Change Was Made
Update requests now send JSON null values for the previous time representation. All-day updates clear
dateTimeandtimeZone. Timed updates cleardate.Evidence
Focused calendar tests pass on the deployed custom branch for both conversions, recurring updates, and restoring reminder defaults.
Dry runs on the upstream patch send
dateTime: nullandtimeZone: nullwith each all-day date, including recurring events.The same changes are under upstream review in openclaw#1349.
make cicompleted formatting and lint checks. Its full test run found two unrelated Gmail failures that reproduce unchanged on the target branchjai/chat-rich-messages:TestGmailDraftsRawDirectTokenRequiresAccountTestGmailSendRawDirectTokenRequiresConcreteAccount