Repository navigation
fix(sm): keep a due schedule when clean_old is set - #1033
Merged
Merged
Conversation
clean_old deleted every row of the entrypoint, then inserted a new next_run. A firing that came due while the scheduler was down was lost even when the expression had not changed.
janbjorge
added
the
Agentic
The NOT EXISTS subquery was harder to read than the keep list. An empty keep still deletes every row of the entrypoint. The clean_old test indexes the kept row with CronExpression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1029.
Summary
clean_old=Truedeletes only schedule rows whose cron expression is no longer registered. An unchanged row keeps itsnext_run, so a firing that came due while the scheduler was down still runs.Testing
uv sync --frozen && uv run ruff check . && uv run ruff format . --check && uv run lint-imports && uv run mypy . && uv run pytestpassedtest_schedule_clean_oldstill drops an expression that is no longer registered, and the kept row keeps its idtest_clean_old_keeps_due_firingandtest_clean_old_keeps_due_firing_postgresbackdatenext_runand confirm the same schedule fires after restarttest_schedule_lifecycleandtest_repository_trace_matchesstill passruffandmypyon the changed modulesChecklist