Repository navigation
refactor(supervisor): take job ends from the manager that owns them - #1035
Merged
Merged
Conversation
QueueManager and PgQueuer expose write_job_ends and unwritten_job_logs. runit replays that list around each cycle. A scheduler has neither, so it is left alone.
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QueueManagerandPgQueuerexposewrite_job_endsandunwritten_job_logs.runitreplays that list around each cycle throughUnwrittenJobLogs.Testing
uv sync --frozen && uv run ruff check . && uv run ruff format . --check && uv run lint-imports && uv run mypy . && uv run pytestpassedtest_pgqueuer_carries_the_queue_managers_unwritten_job_logsshowsPgQueuerandQueueManagercarry the list, and a scheduler does nottest_unwritten_job_logs_stay_held_when_the_write_failskeeps the ends and does not run the bodytest_unwritten_job_logs_capture_what_the_run_could_not_writereplaces the held ends with what the run leftuv run ruff check,uv run mypy, anduv run lint-importspassed on the touched filesChecklist