Repository navigation
fix(qm): retry a failed retry_job write until shutdown - #1039
Merged
Merged
Conversation
janbjorge
added
the
Agentic
5 tasks done
janbjorge
force-pushed
the
fix/retry-job-write
branch
from
October 26, 2026 22:00
76b5f6b to
cea4a18
Compare
A transient failure while persisting RetryRequested was recorded as a terminal failure, so the handler never ran again. Keep the job picked and heartbeating and retry the write. Shutdown leaves the row picked for stale recovery. Fixes #1030
janbjorge
force-pushed
the
fix/retry-job-write
branch
from
October 27, 2026 10:28
cea4a18 to
9d33811
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agentic
Summary
retry_jobwrite is retried while the job stayspickedand the worker keeps heartbeating, instead of being recorded asexceptionorfailed.pickedfor stale recovery, withattemptsunchanged.Testing
uv sync --frozen && uv run ruff check . && uv run ruff format . --check && uv run lint-imports && uv run mypy . && uv run pytestpasseduv run ruff checkanduv run ruff formaton the touched Python files,uv run mypy pgqueuer/core/qm.py --no-incremental, anduv run pytest -n 0 test/test_retry_requeue.py(32 passed).Checklist