Skip to content

Update group-by test to ignore metadata implementation specifics #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeaye merged 2 commits into from
Oct 16, 2026
Merged

Update group-by test to ignore metadata implementation specifics #956

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fcf047
Update `group-by` test to ignore metadata implementation specifics
djblue Oct 16, 2026
a609719
Merge remote-tracking branch 'origin/main' into fix-group-by
djblue Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/clojure/core_test/group_by.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
(let [g (group-by first [[^:foo [1] [2]] [^:bar [1] [3]]])]
(is (= {[1] [[[1] [2]] [[1] [3]]]} g))
;; Metadata should be preserved on grouped items
(is (= {:foo true} (-> g (get [1]) first first meta)))
(is (= {:bar true} (-> g (get [1]) second first meta))))
(is (true? (-> g (get [1]) first first meta :foo)))
(is (true? (-> g (get [1]) second first meta :bar))))

;; Metadata should also be preserved on items and items should
;; stay in the order of the initial collection
Expand All @@ -34,7 +34,7 @@
;; validate order of items in each grouping using attached
;; metadata, which also validates that metadata is preserved
;; on items
(is (= {:a true} (-> s (get true) first meta)))
(is (= {:c true} (-> s (get true) second meta)))
(is (= {:b true} (-> s (get false) first meta)))
(is (= {:d true} (-> s (get false) second meta))))))))
(is (true? (-> s (get true) first meta :a)))
(is (true? (-> s (get true) second meta :c)))
(is (true? (-> s (get false) first meta :b)))
(is (true? (-> s (get false) second meta :d))))))))
Loading