Repository navigation
Add clojure.core-test.with-meta - #959
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The replacement test cannot distinguish correct metadata replacement from incorrect merging.
1 open issue
What changed in this PR
Adds a portable with-meta test namespace to the core test suite.
Changes:
- Tests metadata attachment on literals, constructed collections, and sequences.
- Adds metadata replacement checks and platform-specific invalid-input cases.
- Conditionally tests sorted maps and sets.
| File | Description |
|---|---|
| test/clojure/core_test/with_meta.cljc | Adds portable tests for with-meta behavior. |
Review effort: Balanced
jeaye
requested changes
Oct 17, 2026
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #580