Repository navigation
Add clojure.core-test.reduce-kv - #962
Merged
Merged
Conversation
jeaye
reviewed
Oct 22, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The reduced-result tests need to detect continued reducer calls after early termination.
1 open issue
What changed in this PR
Adds portable clojure.core/reduce-kv tests to the core conformance suite, addressing issue #438.
Changes:
- Covers invalid inputs and platform-specific reducer arity behavior.
- Tests map and vector reductions, empty collections, and reduced results.
- Adds practical examples of key/value transformations.
| File | Description |
|---|---|
test/clojure/core_test/reduce_kv.cljc |
Adds guarded, cross-platform tests for reduce-kv. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Ok, I think this PR should be good for merge. |
Member
|
Thanks, Chris! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #438