Repository navigation
Add jank-build-util package - #18
Conversation
|
I like it. We address the string building problem, the platform checking problem, and we have a single place to consolidate the build helpers. Let's do it. |
|
I've renamed to |
| "CMAKE_INSTALL_BINDIR" "bin" | ||
| "CMAKE_INSTALL_LIBDIR" "lib" | ||
| "CMAKE_INSTALL_INCLUDEDIR" "include"} |
There was a problem hiding this comment.
New default so we don't have to specify these in build files.
| (when (and (not static?) rpath) | ||
| {"CMAKE_INSTALL_RPATH" rpath})))) | ||
|
|
||
| (defn cmake |
There was a problem hiding this comment.
Function is now cmake instead of build, to match the pkg-config function. I think we will :refer these in build scripts.
jeaye
left a comment
jeaye
left a comment
There was a problem hiding this comment.
Nice! I like how this is shaping up. All set to merge and publish this?
|
I will do some testing on other commons packages locally tomorrow, and give you the OK if everything looks good. |
|
OK this is ready to go now, pending CI. |
Adds a package with common build-related utility functions, including a standardized jank build directives API.
I'm also not opposed to moving jank-build-pkg-config and jank-build-cmake into here, since there's not much reason to keep a bunch of tiny build packages around. In which case we could call this package just
jank-buildto be more all-encompassing.What do you think @jeaye?
Will update usages across commons once this gets published.