Option to allow anonymous SSH sessions

[1Hyena]

It's been half a year since I implemented an option to allow SSH guest logins for TinySSH. I created a pull request but it has still not received any reviews nor has it been merged.

Is there any reason for delaying this? It would be helpful to have at least a discussion regarding this enhancement. I would prefer not to create my own fork of TinySSH as a long term solution.

[itdaniher]

FWIW I'd also like to see this enhancement landed. I see plenty of possibilities for an easy to embed ssh-based transport layer.

[hardfalcon]

This is probably out of scope for TinySSH. Quote from https://tinyssh.org/:

Features

• easy auditable - TinySSH has less than 100000 words of code
• simple configuration - TinySSH can’t be misconfigured
• limited amount of features - TinySSH doesn’t have features such: SSH1 protocol, compression, …

[1Hyena]

@hardfalcon have you looked at the code changes?

Still easily auditable as there were trivial changes.

Configuration is still simple.

Limited amount of features? You mean TinySSH should be deliberately crippled? If you look at the changes proposed in the referred pull request it becomes blatantly obvious that with 22 lines of added code the use cases for tinySSH have increased by 50%. Do we really need another competing fork of TinySSH just because of 22 lines of code that increase the usability of TinySSH significantly?

[terefang]

i need to add that i have a similar use case that needs exactly the features as present in the PR above

[terefang]

i have looked in details onto the PR and i think this needs further discussion and engineering work.

what i have seen so far and from my own, i have identified the following features that are related:

1. the ability to have a fallback user if user lookup fails, but authentication via public key is still performed against this fallback users key
2. the users are trusted to being those that is signaled in ssh, disabling authentication entirely, ie. no PK authentication
3. acting as a simple secure transport wrapper for a shell executable (ie. user remains the startup user)
4. a variation on point 1, the fallback user (only) has forced to run a shell executable. (authentication still need to happen)
5. regardless which user is signaled in ssh, the fallback user is used for everything
6. regardless which user is signaled in ssh, each forced to run a shell executable instead of the user shell (authentication still need to happen)

some of the above form their own use cases, some use cases are a combination of the above.

[terefang]

Use Case:

i think this is the intended use case of @1Hyena for the original PR (ie. combining 6 + 5 + 2)

• runing tinysshd, init system agnostic
• tinysshd will always switch to a given user
• tinysshd will always execute a specified command instead of the user shell
• tinysshd will not ssh pk authenticate

reasoning:

• the init system may or may not have the ability to switch to a particular user to run tinysshd under
• tinysshd might not be able to be run by the less-privileged user the executable should run under
• the shell executable may implement its own login system

examples:

• old telnet style text adventures and multi user dungeons (MUD/MUSH)
• console gateways eg. shelling in on serial/usb/etc lines
• terminal gateways eg. shelling into tn3270 or sna terminal services
• first boot configuration system

[terefang]

Proposed Features

• ability to specify a fallback user or force a specific user (-g and -G ?)
• ability to disable authentication for only the fallback case or entirely (-a and -A ?)
• ability to specify an executable for the fallback case (-e ?)
• ability to specify an executable for the regular case (-E ?)
• ability to force an executable for all cases (-F ?)
• include the ability/workaround to run /bin/login

if you think that some of the features might compromise you secure by default policy,
the features could be made optional by wrapping them in defines

[mkrsn]

Anything new here? I would also love to see this feature in TinySSH.

[terefang]

looking at some code of the various github forks, there are some good features that could be reintroduced into the code-base.

i really dont want to hard-fork the code base, as i have no time maintaining it

[janmojzis]

Proposed Features

• ability to specify a fallback user or force a specific user (-g and -G ?)
• ability to disable authentication for only the fallback case or entirely (-a and -A ?)
• ability to specify an executable for the fallback case (-e ?)
• ability to specify an executable for the regular case (-E ?)
• ability to force an executable for all cases (-F ?)
• include the ability/workaround to run /bin/login

if you think that some of the features might compromise you secure by default policy, the features could be made optional by wrapping them in defines

Hi,
I don't agree that tinyssh should have a lot of fallback options. Tinyssh is not feature-rich software,
it's minimalistic software.

I would like to implement this feature very close to @1Hyena's pull request.

• I don't have problem with executing custom shell, I prepared pull request extracted from @1Hyena pull request add -e param., allow to execute custom program instead of shell #60
• But the big question is, how to implement the auth-none option to minimize mistake, examples:
  • (simple -u option) tinysshd -u ... making a mistake is very easy
  • (-u with protection string) tinysshd -u 'iknowwhatimdoing' ... making a mistake is harder, but it's a hack
  • (new binary) tinysshnoneauthd ... tinysshd is always using publickey auth, mistake is almost impossible, but packages must ship more binaries

[terefang]

hmm ... how about:

• doing the symlink trick instead of a new binary ... then check if argv[0] eq tinysshnoauthd ?
• using a long option like --no-auth which must always be in argv[1]

but questions remain, what to do with the user:

• does the username send over ssh need to exist as an user-account ?
• will there be a cli option to specify the user-account in place of the ssh username ?
• could it be executed as the current user-account ?

lacking --no-auth but having -e should execute the given command in place of the normal user-account shell.

in my opinion having both --no-auth and -e should execute as the current user only, so it could be run as non-root.

this behavior would be a good compromise to implementing too many options/features

[janmojzis]

pull request is here: #62
User who needs unauthorized access must:

• use tinysshnoneauthd instead of tinysshd (symlink trick)
• run tinysshnoneauthd under unprivileged user
• unprivileged user must have correct shell
• must include -e customcommand

... I think it's hard to make mistake

[janmojzis]

And #60 #62 merged.
Can anyone independently confirm that it works as expected?

eventually edit/add real-word examples to the man page https://github.com/janmojzis/tinyssh/blob/master/man/tinysshnoneauthd.8

[terefang]

hello

• build the master branch
• ssh connection fails.

looking at the code: packet_auth.c:73 you expect that the ssh client can signal "none" authentication.

i have applied the following patch to make it work:

--- tinyssh/packet_auth.c.old	2022-01-10 17:43:34.000000000 +0100
+++ tinyssh/packet_auth.c	2022-01-10 19:16:48.563463947 +0100
@@ -70,10 +70,6 @@
         pos = packetparser_uint32(b->buf, b->len, pos, &len);       /* publickey/password/hostbased/none */
         pos = packetparser_skip(b->buf, b->len, pos, len);
 
-        if (str_equaln((char *)b->buf + pos - len, len, "none")) {
-            /*
-            if auth. none is enabled get the user from UID
-            */
             if (flagnoneauth) {
                 struct passwd *pw;
                 pkname = "none";
@@ -83,7 +79,8 @@
                 b->len = 0; b->buf[0] = 0;
                 goto authorized;
             }
-        }
+
+        if (str_equaln((char *)b->buf + pos - len, len, "none")) pkname = "none";
         if (str_equaln((char *)b->buf + pos - len, len, "password")) pkname = "password";
         if (str_equaln((char *)b->buf + pos - len, len, "hostbased")) pkname = "hostbased";
         if (str_equaln((char *)b->buf + pos - len, len, "publickey")) {