Repository navigation
Add covariates to Hayes configuration #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JohnnyDoorn
wants to merge
7
commits into
jasp-stats:master
Choose a base branch
from
JohnnyDoorn:feature/hayes-covariates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+608
−33
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
940caa7
feat: add covariates to the Hayes configuration input
JohnnyDoorn a77464e
fix: center and probe moderators on each model's own complete cases
FBartos a418834
fix: stop early for factor levels that clash with the interaction sep…
FBartos ea9bd0a
fix: keep node colours in path plots independent of covariates
FBartos 217f7cb
fix: fit the Bayesian analysis on mean-centered data
FBartos ccfbc04
docs: describe the Covariates box in the help pages, add NEWS entries
FBartos ea1997e
fix: flag model summaries whose information criteria are not comparable
FBartos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A covariate that is also X, M, W, Z or Y is not caught in R. The dialog prevents this because all boxes share one variable list, but through R syntax:
sort.int(...): 'x' must be atomicerror;covNotInGraphalready expects covariates that are in the graph, so I suggest rejecting them here. The message then appears where the DAG message does (on that model's tables and plots), and the other models still run. I checked this locally with the covariate equal to X, M and Y.A related feature gap, not part of this suggestion: since PROCESS v3.2 (19 Nov 2018), a variable that moderates one equation can be a covariate in the other equations (Hayes, PROCESS v3 history and bug fixes). Supporting that needs two changes:
That could be a follow-up.