Repository navigation
build(deps): bump parking_lot from 0.12.5 to 0.13.0 - #389
Conversation
Bumps [parking_lot](https://github.com/Amanieu/parking_lot) from 0.12.5 to 0.13.0. - [Release notes](https://github.com/Amanieu/parking_lot/releases) - [Changelog](https://github.com/Amanieu/parking_lot/blob/master/CHANGELOG.md) - [Commits](Amanieu/parking_lot@parking_lot-v0.12.5...parking_lot-v0.13.0) --- updated-dependencies: - dependency-name: parking_lot dependency-version: 0.13.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
@pullfrog review |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Reviewed the complete dependency update, its resolved graph, and compatibility with the repository's synchronization usage and pinned Rust toolchain.
- Direct dependencies: Updates the shared library and bot to
parking_lot 0.13; the removed APIs and features are not used by these consumers, and upstream's Rust 1.95 minimum is below the repository's 1.96 pin. - Dependency graph: Adds
lock_api 0.5.0andparking_lot_core 0.10.0, while retaining the older versions required by existing transitive dependencies. Checked the upstream API and fairness changes against current lock usage without finding an actionable regression.
Validation: cargo check --locked -p jmodguard -p jmodguard-bot --all-targets and cargo check --locked -p jmodguard-api --no-default-features --all-targets both passed locally. The PR's CI checks, including the Rust, Dylint, supply-chain, and remote-database groups, are green. The full local preflight and runtime contention benchmarks were not rerun.
gpt-6.1-sol | 𝕏
jatmn
left a comment
There was a problem hiding this comment.
✅ LGTM on fd05622. Dependabot parking_lot 0.12.5 → 0.13.0 (Cargo.toml, crates/bot/Cargo.toml, Cargo.lock). The 0.13 bump builds and all CI checks pass, including Sourcery. — jatmn's PR Review agent
|
@pullfrog review |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Reviewed all three changed files at fb16f76, the resolved dependency graph, and compatibility with current synchronization usage.
- Direct dependencies: Moves the shared library and bot to
parking_lot 0.13. The removed APIs and features are not used, and the upstream Rust 1.95 minimum is compatible with the repository's Rust 1.96 pin. Checked the changed fairness behavior against existing lock consumers without finding a concrete regression. - Lockfile resolution: Adds
lock_api 0.5.0andparking_lot_core 0.10.0, retaining the older synchronization stack for transitive consumers such as libSQL, Serenity, and sessions.
Validation passed locally: cargo check --locked -p jmodguard -p jmodguard-bot --all-targets, cargo check --locked -p jmodguard-api --no-default-features --all-targets, and bash scripts/check-service-boundaries.sh. Current-head CI is green, including Rust, Dylint, supply-chain, and remote-database checks. The full local preflight and contention benchmarks were not rerun; no live provider calls were made. The worktree is unchanged.
gpt-6.1-sol | 𝕏
jatmn
left a comment
There was a problem hiding this comment.
✅ LGTM on fb16f76. The main merge adds nothing new to this PR's diff: still the parking_lot 0.12.5 → 0.13.0 bump (Cargo.toml, crates/bot/Cargo.toml, Cargo.lock). All CI checks green, including Sourcery and Pullfrog. — jatmn's PR Review agent

Bumps parking_lot from 0.12.5 to 0.13.0.
Release notes
Sourced from parking_lot's releases.
... (truncated)
Changelog
Sourced from parking_lot's changelog.
... (truncated)
Commits
1a5c3ddUpdate changelogec07063chore: releasef369d24Merge pull request #538 from napi-rs/wasi-threads-parker2f4103fRemove the WASI backend note from stable restrictionsa3e8717Reuse existing CI jobs for WASI coveragec2bfc7bMerge pull request #549 from Amanieu/fix-l4re-condvar-clock696f28bDon't use pthread_condattr_setclock on L4RE52941c0Share the libc dependency between Unix and WASI4fde6a7Align the Rust setup action with existing workflowsf0ce547Reuse the pthread backend for WASI on stableDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)