Skip to content

campaign-controller(warren-442e): accept GitHub App bot logins '<owner>… - #1178

Merged
jayminwest merged 11 commits into
mainfrom
warren/run_3pg4yqhm6b0c
Aug 29, 2026
Merged

campaign-controller(warren-442e): accept GitHub App bot logins '<owner>…#1178
jayminwest merged 11 commits into
mainfrom
warren/run_3pg4yqhm6b0c

Conversation

@warren-run-bot

Copy link
Copy Markdown
Collaborator

Summary

campaign-controller(warren-442e): accept GitHub App bot logins '[bot]' in bot grammar validation

Run

  • Warren run: run_3pg4yqhm6b0c
  • Agent: pi

Commits (9)

  • ad8b14b campaign-controller(warren-442e): accept GitHub App bot logins '[bot]' in bot grammar validation
  • bc48e84 campaign-controller(warren-442e): pin App bot login validation — bracket form accepted, malformed forms refused
  • 4edeaf7 campaign-controller(warren-442e): rewrite openclaw bot grammar from observed ClawSweeper format
  • eb78bc2 campaign-controller(warren-442e): openclaw e2e fixture moved to observed ClawSweeper format
  • 6ebcb79 campaign-controller(warren-442e): pin the openclaw bot-grammar golden against the observed ClawSweeper format
  • da27bc6 campaign-controller(warren-442e): classifier test parsing the observed ClawSweeper finding line verbatim
  • d63b6d5 campaign-controller(warren-442e): biome formatting on new pinned tests
  • 37fca0c seeds: adopt origin/main queue and close warren-442e (bot grammar fixed)
  • f8761f6 mulch: update expertise

Files changed

.../profiles/openclaw.bot-grammar.json             |  8 +++----
 .../__golden__/second-profile-fixtures.json        |  6 ++---
 .../src/openclaw-profile.test.ts                   | 23 ++++++++++++++++++
 .../src/reconcile/bot-grammar.test.ts              | 20 ++++++++++++++++
 .../src/reconcile/bot-grammar.ts                   | 23 ++++++++++++++++--
 .../src/reconcile/classifier.test.ts               | 28 ++++++++++++++++++++++
 6 files changed, 99 insertions(+), 9 deletions(-)

Prompt

Show prompt
Work seeds issue warren-442e in the warren repo. First run `sd show warren-442e --json` from the repo root — the issue body is the full spec with the exact observed formats; follow it precisely. Digest: two defects in extensions/campaign-controller — (1) validateBotGrammar rejects GitHub App bot logins like 'clawsweeper[bot]' (isValidOwner refuses brackets) though the classifier exact-matches the API's literal bracket login; accept '<owner>[bot]' by validating the inner name. (2) profiles/openclaw.bot-grammar.json is stale fiction; rewrite it from the observed ClawSweeper format in the issue body, update the pinned openclaw-profile golden test, and add a test parsing the observed finding line verbatim. Work from extensions/campaign-controller (standalone package): run its own `bun test`, `bun run lint` — note typecheck/lint have pre-existing failures on main tracked as warren-c26c in files you must not touch; your changed files must be clean and the test suite must pass. Commit incrementally as soon as each coherent change compiles, before validation. Close warren-442e with `sd close` when done.

🤖 Opened by warren run run_3pg4yqhm6b0c

@jayminwest
jayminwest enabled auto-merge (squash) August 28, 2026 22:10
Semantic merge conflict between #1175 and #1178: the e2e loads the
profile grammar (now the real clawsweeper[bot] format) but seeded the
comment in the pre-observation clawreview-bot shape, so feedbackCreated
stayed 0.
@jayminwest
jayminwest merged commit e316e54 into main Aug 29, 2026
8 checks passed
@jayminwest
jayminwest deleted the warren/run_3pg4yqhm6b0c branch August 29, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants