Skip to content

fix(scorm2004): honor shared-data default - #599

Merged
jcputney merged 2 commits into
mainfrom
fix/scorm-2004-shared-data-default
Sep 9, 2026
Merged

jcputney merged 2 commits into
mainfrom
fix/scorm-2004-shared-data-default

Conversation

@jcputney

@jcputney jcputney commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • represent adlcp:sharedDataGlobalToSystem as nullable so attribute presence is preserved
  • apply the SCORM 2004 default of true when the attribute is omitted
  • retain an explicitly authored false value

Testing

  • ./mvnw -Dtest=Scorm2004ManifestTest test
  • ./mvnw test (1,245 tests, 0 failures)

@github-actions github-actions Bot added area-input Input models/ingest type-tests Unit/integration tests labels Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

📊 Benchmark Results

Triggered by workflow run.

Benchmark Score Error Unit
🟢 detectModuleType 0.001 ±0.000 ms/op
🟢 parseModule 1.044 ±2.293 ms/op
🟢 detectModuleType 0.000 ±0.000 ms/op
🟢 parseModule 0.069 ±0.055 ms/op
🟢 detectModuleType 0.159 ±0.694 ms/op
🟢 parseModule 0.512 ±0.902 ms/op
🟢 detectModuleType 0.100 ±0.018 ms/op
🟢 parseModule 1.342 ±3.638 ms/op

✅ All benchmarks passed performance thresholds.

@jcputney
jcputney enabled auto-merge September 9, 2026 21:07
@jcputney
jcputney merged commit 41a9933 into main Sep 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-input Input models/ingest type-tests Unit/integration tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant