[MythreyaK]

I have a basic devcontainer extension here, and wanted to get devcontainer on a remote ssh machine working. There is a lot of work left to be done on the devcontainer parts itself, but I was hoping we can start planning towards chaining.

The corresponding branch on the devcontainer side is here. Install both, and open a workspace with a devcontainer configuration. You should be able to "reopen in container".

Note: Updated after a rewrite of both this PR and the supporting extension.

[MythreyaK]

@jeanp413 @daiyam hope you don't mind the ping : )

[daiyam]

I will need some time to review your PR and evaluate the possible security issues from createExecServer.

Firstly, unedit package.json.
Secondly, I don't see any call to resolveExecServer() even in your project.

[MythreyaK]

I will need some time to review your PR and evaluate the possible security issues from createExecServer.

Of course, yeah, not urgent. This isn't meant to be merged as is, so I should probably make this a draft. Just wanted to discuss.

Firstly, unedit package.json.

I originally made that change to differentiate the local build from the upstream version. Will do both of those tomorrow 👍.

Secondly, I don't see any call to resolveExecServer() even in your project.

It should be on this branch.

I'm working on a rewrite of the devcontainer extension so I'll update this pr as well once it's a little more ready.

[daiyam]

Secondly, I don't see any call to resolveExecServer() even in your project.

It should be on this branch (this commit).

It's an API from VSCode.

[MythreyaK]

resolveExecServer is implemented in the first hop, so this PR. Once the SSH connection is established, the devcontainer extension uses it for exec-spawn on the remote machine, is my mental model of the API. Please correct me if I'm wrong here!

[MythreyaK]

This should be ready for review and testing it out. You can download the CI build artifact from this PR (MythreyaK/open-remote-devcontainer#2) here to test both SSH and devcontainer together.

[MythreyaK]

Been trying to see if I could roll in windows support too ... Haven't had a chance to test it yet, but if you'd prefer to see it supported in this PR (instead of in a new one), do let me know.

[daiyam]

There is already several PRs for windows but take a look at #343

I really need to take some times and review all those PRs and yours.

[MythreyaK]

There is already several PRs for windows but take a look at #343

Thanks for the pointer!

I really need to take some times and review all those PRs and yours.

Sure, sounds good, thanks for your time!

[MythreyaK]

Ran into mscdex/ssh2#1396 on https://github.com/jeanp413/ssh2.

ssh2 in this extension might need a bump 🤔?