feat: add CompetencyTaxonomy.taxonomy_overrides_org - #3
Open
jesperhodge wants to merge 2 commits into
Open
jesperhodge wants to merge 2 commits into
jesperhodge wants to merge 2 commits into
Conversation
jesperhodge
force-pushed
the
jesperhodge/cbe-641-03-taxonomy-overrides-org
branch
from
September 9, 2026 21:26
fcd7fbc to
05486f0
Compare
jesperhodge
force-pushed
the
jesperhodge/cbe-641-03-taxonomy-overrides-org
branch
2 times, most recently
from
September 10, 2026 19:03
738f5ec to
8d529fd
Compare
jesperhodge
added this pull request to stack #11
September 11, 2026 13:17
jesperhodge
force-pushed
the
jesperhodge/cbe-641-03-taxonomy-overrides-org
branch
from
September 11, 2026 13:27
8d529fd to
93e3dba
Compare
jesperhodge
commented
Sep 11, 2026
jesperhodge
commented
Sep 11, 2026
jesperhodge
removed this pull request from stack #11
September 11, 2026 14:29
jesperhodge
added this pull request to stack #12
September 11, 2026 14:33
jesperhodge
removed this pull request from stack #12
September 11, 2026 14:34
jesperhodge
added this pull request to stack #13
September 11, 2026 14:34
mgwozdz-unicon
approved these changes
Sep 14, 2026
mgwozdz-unicon
left a comment
mgwozdz-unicon
left a comment
There was a problem hiding this comment.
Approved, but Claude and I have a nit: It would probably be nice to refer to the CompetencyRuleProfile or "Competency Rule Profile" in full in both the models file and migrations file rather than just shortening to "profile" to make sure anyone new to the concepts/context here knows what's being referred to.
PR openedx#712 shipped CompetencyTaxonomy without this column. It settles a tiebreak that cannot arise yet: when a criterion could inherit its rule from an organization-scoped CompetencyRuleProfile or from a taxonomy-scoped one, this flag decides which wins (ADR-0002 Decision 4). Organization-scoped profiles do not exist, so no code path reads it. Adding the column now avoids a later migration against a table that by then has learner data hanging off it. Turns cbe/models.py into a models/ package, since the three criteria models that follow form one connected structure and want a module of their own. Refs openedx#641 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Jesper Hodge <19345795+jesperhodge@users.noreply.github.com>
jesperhodge
force-pushed
the
jesperhodge/cbe-641-03-taxonomy-overrides-org
branch
from
September 14, 2026 16:40
e486543 to
490f05a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of 7 for issue openedx#641. Based on part 2.
What this does
Adds
CompetencyTaxonomy.taxonomy_overrides_org.Turns
cbe/models.pyinto amodels/package.Verifying
Refs openedx#641