Provide the highest and lowest values at the end of the report. - #77
Open
mehdinourollah wants to merge 1 commit into
Open
mehdinourollah wants to merge 1 commit into
mehdinourollah wants to merge 1 commit into
Conversation
jesusprubio
requested changes
Nov 19, 2024
jesusprubio
left a comment
jesusprubio
left a comment
Owner
There was a problem hiding this comment.
Thank you. This is interesting in some scenarios, like setting a target using only one protocol. So we need to add a new option to the CLI to enable this.
| @@ -1,4 +1,3 @@ | |||
| // Package main implements a simple CLI to use the library. | |||
Owner
There was a problem hiding this comment.
Please re-add this comment, the linter requires a comment for each package.
| defer cancel() | ||
| // Only used for debugging. | ||
|
|
||
| // Logging setup |
Owner
There was a problem hiding this comment.
Please remove all blank likes and comments you added. They are redundant and we do not use empty lines inside functions.
| if opts.NoColor { | ||
| color.NoColor = true | ||
| } | ||
| // To wait for termination signals. |
Owner
There was a problem hiding this comment.
The old comment is more informative.
|
|
||
| // Variables to track highest and lowest response times | ||
| var maxTime, minTime time.Duration | ||
| firstReport := true |
Owner
There was a problem hiding this comment.
We don't need this var. Just check if both values are zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be great if this could be provided as a real-time update. If I were able to make it work, I鈥檒l create another pull request, but for now, this was a useful feature for me.