Repository navigation
Conversation
Signed-off-by: Jiagan Cheng <jiaganc@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Description
This PR removes redundant recurrent-state and metadata movement from Kimi K3 KDA prefill.
Mamba2Metadataas the lazy default for generic attention metadata to avoid an import cycle, while selecting the Kimi K3 metadata subclass in the executor.This is a stacked draft targeting
codex/kda-refactor-part-1. The branch contains one squashed commit beyond that base.Test Coverage
100-realon B200.test_kda_prefill_op.pytest_kimi_k3_mamba_metadata.pytest_kimi_kda_fused_verify_parity.pytest_kimi_kda_verify_parity.pytest_gdn_kernel_optimizations.pytest_recurrent_state_cache.pyPR Checklist
Please review the following before submitting this PR:
PR description clearly explains what and why.
PR follows the TRT-LLM coding guidelines to the best of my knowledge.
Test cases cover the new code paths.
No public API or dependency changes are introduced.
Documentation, CODEOWNERS, and architecture diagram updates are not required for this internal optimization.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, comment
/bot help.