Repository navigation
build: hold MSVC to /W4 /WX like GCC and Clang (0082) - #478
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G9u5hgS7vcar6yNGvnx3Xp
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G9u5hgS7vcar6yNGvnx3Xp
… shows it (0082, temporary) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G9u5hgS7vcar6yNGvnx3Xp
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G9u5hgS7vcar6yNGvnx3Xp
rmorozov
marked this pull request as ready for review
October 12, 2026 13:40
…ow-up) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G9u5hgS7vcar6yNGvnx3Xp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ruslan · project thread
Before: MSVC builds never saw the strict warning flags (
/W4sat insideif (UNIX)) and nothing passed/WX, so MSVC-only warnings went unnoticed while GCC and Clang failed on-Wall -Werror.After: MSVC builds the library and the tests with
/W4 /WX /external:W0 /wd4702, so all three compilers are held to the same bar. All three Windows jobs (C++17 Release, C++20 Debug shared, C++23 Debug) are green under/WX.Task 0082 (status set to in-progress; the task file records what was measured).
How:
/W4was measured first on Windows CI, which reported two distinct warnings:std::getenvintest/parity/parity_test.cpp: under MSVC it now uses_dupenv_s.fmt/base.h:/external:W0does not silence it because the code generator reports it after the external-header filter, so it is suppressed with/wd4702and a comment. The cost is that a real C4702 in project code is also hidden; revisit when fmt is bumped.Only the strict-warnings block in
CMakeLists.txtchanged there (0068 and 0069 touch other parts of the file); master was merged in once (no conflicts).Roles: main session only, plus two
ci-triagereads of the Windows logs to collect the warnings; no verifier round (CMake flag and one test-file change, nosrc/orinclude/change). Red pushes: 0. (The first measurement push had no/WX; a temporary CI step to print warnings was added and removed.)🤖 Generated with Claude Code
https://claude.ai/code/session_01G9u5hgS7vcar6yNGvnx3Xp