Repository navigation
fix: call block on an undefined or non-callable name fails at render (0156) - #487
Merged
Merged
Conversation
…r (0156) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TTbrLyoY9DSFiiy2xJfcEb
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TTbrLyoY9DSFiiy2xJfcEb
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TTbrLyoY9DSFiiy2xJfcEb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ruslan · project thread
Before:
{% call m() %}{% endcall %}rendered nothing whenmwas undefined or not callable (e.g.{% set m = 1 %}), and a user expression callable was silently skipped.After: an undefined name raises UndefinedError (through the undefined policy, as a call expression does), a non-callable value raises "'int' object is not callable", and an expression callable is called with
callerand its result is written, as in Jinja2.The change is in
MacroCallStatement::Render(src/statements.cpp). It reusesCheckUndefinedUse(..., Call)and the not-callable message fromCallExpression.How: three corpus cases in
test/parity/cases/statements.py(call_block_undefined,call_block_int,call_block_string) with regenerated expected output (Python 3.12, jinja2 3.1.6). No allow-list lines existed for 0156, so none were deleted. Task 0156 marked done. Roles: none (main session only), no verifier round.🤖 Generated with Claude Code
https://claude.ai/code/session_01TTbrLyoY9DSFiiy2xJfcEb
Generated by Claude Code