Repository navigation
parity: from-import of one name under two names (0155) - #497
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ctbo7iuiuCyogEmypUtQ28
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ctbo7iuiuCyogEmypUtQ28
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ctbo7iuiuCyogEmypUtQ28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ruslan · project thread
Before:
{% from 'm' import a, a as b %}kept only the last alias per name, soastayed undefined and the output was7.After: every
name as aliaspair is bound in source order, so the output is77as in Jinja2.The parser no longer merges pairs by name;
ImportStatement::ImportNamesalready looped over all of them.How: removed the dedup in
ParseFrom(src/template_parser.cpp). Added corpus casesloader.from_import_name_twiceand..._same_alias, updatedNodeArenaTest.LongNamesFromTheTree(7 → 77) and madeManyImportedNamesrepeat a name past 16. No divergence lines existed for this case. Task 0155 set to done.Roles: verifier ran 1 round (READY, 54 templates match Python Jinja2, ASan/UBSan clean on Clang), preflight incl.
--perfpassed. No red pushes yet.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ctbo7iuiuCyogEmypUtQ28
Generated by Claude Code