Conversation
chadwick_register() checked only whether the local chadwick-register.csv existed, with no expiration check, so once a user called it with save=True the local copy was trusted forever and new players added upstream (e.g. new rookies) were never picked up. Added an age check against the existing cache.config.default_expiration threshold, matching the pattern already used elsewhere in the cache system. Fixes jldbc#493
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chadwick_register() checked only whether the local chadwick-register.csv existed, with no expiration check, so once a user called it with save=True the local copy was trusted forever and new players added upstream (e.g. new rookies) were never picked up. Added an age check against the existing cache.config.default_expiration threshold, matching the pattern already used elsewhere in the cache system.
Fixes #493