Conversation
## Summary Already in place and unchanged: - 3.9+ drop-in for stdlib `difflib`, with no runtime dependencies - scikit-build-core + CMake - sdist without Cython after generate + `tools/sdist.patch` - pip/cibuildwheel as the published path This PR adds 3.14 and free-threaded 3.14t support and the Cython / concurrency work those builds require. ## Problem - No 3.14 or free-threaded 3.14t wheels. - Cython was `>=3.0.12,<3.1.0`. 3.14t does not compile on Cython 3.0.x. - No `# cython: freethreading_compatible=True`, so a 3.14t import re-enables the GIL. - No documented or tested concurrency contract. `SequenceMatcher` scratch is per-instance; sharing one matcher across threads is unsupported (same as stdlib). `HtmlDiff._default_prefix` is process-wide. - Local uv workflow was not set up (optional; not a user-facing break). ## Changes - Cython `>=3.3.0,<3.4` (build-only); scikit-build-core `>=1.0`; CMake max 3.30. - `freethreading_compatible=True` pragma; `HtmlDiff._default_prefix` lock; docs; `tests/test_concurrency.py`. - Wheel matrix includes 3.14/3.14t with cibuildwheel 4.2.1 and small portability fixes (3.9 `zip` without `strict=`, skip thread tests when threads cannot start, Windows ARM64 delvewheel exclude MSVC CRT); Intel Mac CI uses macos-15-intel because macos-13 runners are retired. - Optional local uv (`uv.toml` / `uv.lock`); no `.python-version`; `AGENTS.md` is contributor docs only. ## Compatibility - Python 3.9+ and the public API are unchanged. - Optional uv does not change pip, conda, thefuzz, PyPy, or sdist-without-Cython. CI stays on pip. ## Dependencies - Runtime: none. - Build: Cython and scikit-build-core bumps (cmake/ninja stay out of `build-system.requires`). - Dev: optional `pytest>=8`. ## Test plan - Local pytest on 3.11, 3.12, 3.13, 3.14, and 3.14t. - Isolated wheel build. - CI matrix including 3.14/3.14t.
Wheel jobs already install each tag and run the test suite; the sdist job only compiled. Match RapidFuzz’s install-then-pytest step and document which cibuildwheel skips stay build-only. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-only CI validation of rapidfuzz/CyDifflib#9. Same two commits (
6fc166f,3c0eefd) as that PR. No changes were made to the upstream repo or its PR.Upstream Actions does not report checks on rapidfuzz#9. This draft exists so the same
Buildworkflow can run here onpushandpull_request.Do not merge unless we want these commits on
jlevy/CyDifflibmain.GitHub Actions (finished)
Both runs succeeded. No failed jobs. The only skipped job is
deploy wheels to pypi, which is correct: that job isif: github.event_name == 'release'.That includes Linux
cp314/cp314t, Windows, macOS 14 / 15-intel, qemu aarch64/ppc64le/s390x, PyPy, and pyodide.The same SHA also passed earlier on the original head branch: https://github.com/jlevy/CyDifflib/actions/runs/35428187078
Local validation
Built with
CC=gcc CXX=g++on this VM. Exact PR tree at3c0eefd.The single skip is
test_gil_stays_disabled. That is intentional:sys._is_gil_enableddoes not existPy_GIL_DISABLEDis unsetSdist path: generate
.cxx, applytools/sdist.patch, install tarball with no Cython present, pytest 31 passed.