Target net10.0/net11.0, upgrade xunit v4, modernize CI - #22
Merged
Merged
Conversation
- Narrow TargetFrameworks to net10.0;net11.0 (drop net8.0/net9.0) - Bump actions/checkout to v7, actions/setup-dotnet to v6 (split into separate GA/preview steps so dotnet-quality: preview no longer forces .NET 10 off its GA channel), gittools/actions to v4.7.0 - Upgrade Microsoft.NET.Test.Sdk, xunit.v3 and xunit.runner.visualstudio to their new major versions, which require opting into the new MTP dotnet test runner via global.json (also pins the min SDK, rolling forward to the newest installed major so it keeps working once .NET 11 leaves RC) - Add renovate.json to keep NuGet/Actions versions from going stale again Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Each matrix leg installs only the SDK/runtime it needs (10.0.x GA, 11.0.x preview) and scopes restore/build/test to that single TargetFramework via -p:TargetFrameworks=, avoiding the earlier NETSDK1045 failure that occurs when a lower SDK sees a TargetFrameworks list containing a newer TFM it doesn't understand. Legs run in parallel instead of two sequential setup-dotnet steps in one job. +semver: major This branch drops net8.0/net9.0 support from NoCommons, a breaking change for consumers on those TFMs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TargetFrameworkstonet10.0;net11.0, dropping net8.0/net9.0actions/checkoutto v7 andactions/setup-dotnetto v6 in all three workflows, split into separate GA (.NET 10) and preview (.NET 11) setup steps sodotnet-quality: previewno longer forces .NET 10 off its GA channel; bumpgittools/actionsto v4.7.0Microsoft.NET.Test.Sdk,xunit.v3, andxunit.runner.visualstudioto their new major versions, and migrate the test project to the new MTPdotnet testrunner viaglobal.json(test.runner), which also pins the minimum SDK withrollForward: latestMajorso it keeps resolving once .NET 11 moves past RCrenovate.jsonso future NuGet/GitHub Actions version drift is caught automatically (once the Renovate GitHub App is installed on the repo)Test plan
dotnet test source— clean restore/build/test, 176/176 passing across net10.0 and net11.0dotnet --versionresolves to the newest installed SDK (11.0.100-rc.1) via the newglobal.jsonsdkblocksetup-dotnetsteps correctly install both GA .NET 10 and preview .NET 11 on the GitHub-hosted runner🤖 Generated with Claude Code