Compile grounded subpatterns into hash-cons lookups - #28
Draft
jonathanvdc wants to merge 1 commit into
Draft
jonathanvdc wants to merge 1 commit into
jonathanvdc wants to merge 1 commit into
Conversation
JMH comparison (baseline vs PR)
Note: < 1.0× means faster on PR; > 1.0× means slower. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a subpattern is fully bound, matching still enumerates candidate nodes and compares their children. These changes compile subtrees without explicit slots into a
Lookupinstruction instead: forf(g(x), h(x)), oncexis bound throughg, look uph(x)and compare its e-class with the expected call.Calls carrying slots retain structural matching. Incremental saturation recompiles standard lookup tapes without the optimization so its per-node top-k checks remain intact; custom tapes containing lookups must disable the optimization before instrumentation.
Regression tests for are included for equivalent matches, missing nodes, wrong classes, unions, register layout, early termination, failure reporting, and slotted fallback. The branching test reduces candidate visits from 102 to 2 plus one lookup.