Skip to content

14 scripts carry cosmetic brace-injection damage (};//, comments swallowed); compile but outline degraded #890

Open

Description

@jsavin

Rationale

14 additional scripts carry COSMETIC brace-injection damage from the 13103f0→#581 import chain — they COMPILE (invisible to any compile sweep) but their stored outline no longer matches the authored comment hierarchy. Signature: "};//" (comment text swallowed after an injected close-brace). Invisible to functional tests but degrades code readability and maintainability. All are repairable from pre-13103f032 mirrors (verified round-trip-stable).

Current State

Cosmetic brace-injection damage identified (provenance: commits 13103f0 and #581):

Affected scripts (14 total):

  1. system.menus.handlers.repl.help
  2. system.menus.handlers.repl.clear
  3. system.menus.handlers.repl.keycodes
  4. system.menus.handlers.repl.exit
  5. script.newScriptObject (ITSELF damaged)
  6. op.newOutlineObject (ITSELF damaged)
  7. html.dialog.draw
  8. soap.rpc.client
  9. xml.rss.formatDrivers.feed.compile
  10. Manila wizard.callbacks.customRenderer
  11. Manila wizard.callbacks.getValue
  12. Manila wizard.callbacks.setValue
  13. xmlStorageSystem wizard.callbacks.getValue
  14. xmlStorageSystem wizard.callbacks.setValue

Impact:

  • Scripts compile successfully (invisible to compile sweep)
  • Stored outline structure diverged from authored hierarchy
  • Code readability degraded (comments swallowed)
  • Maintainability impact (outline navigation confused by missing structure)
  • No functional impact (comment injection doesn't break execution)

Desired Outcome

Repair all 14 scripts from pre-13103f032 mirrors (verified round-trip-stable):

  1. Restore correct outline hierarchy
  2. Verify compile after repair (should remain green)
  3. Verify no functional regression (comments are cosmetic)

Recommendation

Repair source: Pre-13103f032 mirrors (verified stable)

git show 13103f032^:usertalk_scripts/system/menus/handlers/repl/help.ut

Repair method: Reinstall each via script.newScriptObject using the correct pre-13103f032 source

Integration: Natural home is root-build plan's Step 5 (repair-in-text) — repair all three damage classes together:

Exit Criteria

  • All 14 scripts reinstalled from pre-13103f032 mirrors
  • Verify: all 14 compile successfully after repair
  • Verify: no functional regression (comments are cosmetic)
  • Verify: outline hierarchy restored (comments visible in outline navigation)
  • Cross-check: no other scripts carry similar brace-injection damage

Related Context

Damage Class Definition

Cosmetic brace-injection damage: Signature "};//" (injected close-brace swallows subsequent comment text). Invisible to compile (scripts remain valid) but outline structure diverged from authored hierarchy. Contrast with functional corruption (#879, #881) where scripts fail or behave incorrectly.

Prevention

Future modernization passes (sed, mass edits) on mirror corpus must:

  1. Include compile verification (catch brace-injection immediately)
  2. Preserve outline structure (validate comments are intact)
  3. Use structural tools, not regex (avoid sed traps)
  4. Test round-trip: mirror → ODB → mirror idempotent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority/p2Medium priority - nice to havescope/medium1-2 weeks, requires design worktype/bugDefect in existing functionality, needs fixworkstream/database-architectureDatabase format, migration, serialization

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions