Repository navigation
Install npm packages in the frontend command - #858
Merged
Merged
Conversation
ddev frontend only ran the build, so after a PR that changed package-lock.json the local node_modules stayed on the old versions and the build used them. Run npm ci first, skipping lifecycle scripts so the postinstall hook does not build the CSS a second time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ddev frontendonly rannpm run build, so after a PR that changedpackage-lock.jsonthe localnode_modulesstayed on the old versions and the build silently used them. After the frontend group bump in Bump the frontend group with 7 updates #856, all 7 bumped packages were still at their previous versions locally.npm cifirst. It passes--ignore-scriptsbecausepackage.jsonhas apostinstallhook that runs the build, which would otherwise build the CSS twice. The build then runs explicitly once.Testing
ddev frontendinstalls 167 packages,npm lsreports no version mismatches, and the build runs once withstyles.cssunchanged.ddev frontendand later runs its ownnpm cion the runner, which is unaffected by this change.