add workflow name to recent builds - #19
Open
mathieux51 wants to merge 1 commit into
Open
mathieux51 wants to merge 1 commit into
mathieux51 wants to merge 1 commit into
Conversation
jszwedko
reviewed
Nov 22, 2021
jszwedko
left a comment
jszwedko
left a comment
Owner
There was a problem hiding this comment.
Hi @mathieux51 ! Thanks for this.
👍 to adding go.mod
I just had one question below about repurposing the subcommand.
Could you provide a screenshot or copy/paste the output to show the before/after of this change?
Comment on lines
-244
to
+245
| Name: "recent-builds", | ||
| Aliases: []string{"recent"}, | ||
| Name: "recent", | ||
| Aliases: []string{"r"}, |
Owner
There was a problem hiding this comment.
Should we leave the existing subcommand and add a new one for showing recent workflows?
Author
There was a problem hiding this comment.
We can create a new command for sure.
Author
|
If I run it on this repo, this is before: and this it after: The command I'm running most of the time is: which is related to #17. If you like us to move forward with this we could:
As I wasn't sure you would accept the changes I took a shortcut but I'm happy to contribute back to the project. |
Owner
|
Thanks @mathieux51 ! I agree with your list of separate PRs. Would you want to go that route? Given the before/after you have there, I'm happy to see this stay as an enhancement to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.