Skip to content

Fix order of the sl_n and sl_k pointers in ScsCone constructor - #360

Merged
odow merged 3 commits into
masterfrom
od/fix-claude-001
Sep 7, 2026
Merged

Fix order of the sl_n and sl_k pointers in ScsCone constructor#360
odow merged 3 commits into
masterfrom
od/fix-claude-001

Conversation

@odow

@odow odow commented Sep 7, 2026

Copy link
Copy Markdown
Member

Looks like it's just a typo from #327, but I still need to make a proper test.

Upstream uses

https://github.com/cvxgrp/scs/blob/35b491dfdead5e4bab595f48f6c9cb2aab868dc5/include/scs.h#L174-L176

image

@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.68%. Comparing base (02f2ff4) to head (5cfe74f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files          12       12           
  Lines         663      663           
=======================================
  Hits          641      641           
  Misses         22       22           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odow

odow commented Sep 7, 2026

Copy link
Copy Markdown
Member Author

@araujoms okay with this? Or were you passing the arguments reversed in scs_solve?

@araujoms

araujoms commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Me? I never used this cone. Change seems correct though.

@odow
odow merged commit 436df40 into master Sep 7, 2026
12 checks passed
@odow
odow deleted the od/fix-claude-001 branch September 7, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants