Skip to content

Remove hardcoded 14-day token lifetime from auth cookie handling - #3732

Merged
briehl merged 3 commits into
developfrom
fix/token-lifetime-remove-hardcoded-default
Jul 31, 2026
Merged

briehl merged 3 commits into
developfrom
fix/token-lifetime-remove-hardcoded-default

Merge branch 'develop' into fix/token-lifetime-remove-hardcoded-default

8b47954
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 31, 2026 in 0s

25.94% (+0.01%) compared to b12dae7

View this Pull Request on Codecov

25.94% (+0.01%) compared to b12dae7

Details

Codecov Report

❌ Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.94%. Comparing base (b12dae7) to head (8b47954).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
kbase-extension/static/kbase/js/narrativeLogin.js 0.00% 5 Missing ⚠️
kbase-extension/static/kbase/js/api/auth.js 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3732      +/-   ##
===========================================
+ Coverage    25.92%   25.94%   +0.01%     
===========================================
  Files          461      461              
  Lines        46697    46700       +3     
===========================================
+ Hits         12106    12116      +10     
+ Misses       34591    34584       -7     
Files with missing lines Coverage Δ
kbase-extension/static/kbase/js/api/auth.js 92.55% <50.00%> (-1.14%) ⬇️
kbase-extension/static/kbase/js/narrativeLogin.js 42.37% <0.00%> (-1.49%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee9de1b...8b47954. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.