Repository navigation
fix(server): validate config, preserve reload state, and drain requests - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invalid policies could panic, ignored capacity changes could take effect on later reloads, and policy changes reset bench mode. Validate configuration before use, provide upstream defaults for partial files, preserve effective restart-only settings and mode, and retain the active cache when a reload is invalid. Existing invalid startup files now fail clearly instead of silently using defaults.
Watch the parent directory so atomic file replacement and later file creation are detected, and keep the watcher owned by main. Wait for both HTTP servers to drain; previously the idle metrics server could finish first and drop active proxy requests.
Validation: 56 Rust tests (including the prerequisite), including four configuration regressions; cargo fmt; strict Clippy across all targets. Combined end-to-end smoke checks exercised atomic reloads, consecutive rejected capacity changes, invalid reload preservation, and SIGTERM while a request was in flight.
This PR is stacked on #14 because the current CI Rust compiler rejects the original load-generator division code. Merge #14 first; the diff here contains only this improvement family.
Replaces #10 after removing the codex/ branch prefix. Commit contents are preserved; the original PR retains prior discussion and review history.